[Major] Separate plotting dependencies to enable running without plotting - #1611
Draft
kneureither wants to merge 3 commits into
Draft
[Major] Separate plotting dependencies to enable running without plotting#1611kneureither wants to merge 3 commits into
kneureither wants to merge 3 commits into
Conversation
added 3 commits
July 4, 2024 12:05
…otting_backend()`, catch with a warning and prevent plotting.
Contributor
Author
|
Can you give some feedback on the approach @ourownstory? Is that how you envisioned this to work? I would add further libraries to the plotting group and deal with them in the same manner as with plotly. I used a specific group instead of specifying the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔬 Background
Poetry can now be installed in a minimal mode by using
poetry install --only main. Minimal mode does only include the main dependencies, specified under[tool.poetry.dependencies]. Matplotlib could also be excluded in the future, by moving it into the[tool.poetry.group.plotting.dependencies]inpyproject.toml.All tests are passed, except
test_model_performance.pywhich saves svg files.fixes issue #1548.
🔮 Key changes
forecaster.py,plot_forecast_plotly.py,plot_model_parameters_plotly.py) and display warning, but proceed without plotting anything.plotting_backendwhich is set to"no-backend-installed"📋 Review Checklist